Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noload option appended #7

Open
wants to merge 22 commits into
base: atom-v3.3.1
Choose a base branch
from

Conversation

EnvyusKennys
Copy link

Describe what this PR does

Adding noload option for readonly mount condition to avoid journal replay

Provide any external context for the change, if any.

From log:

Warning FailedMount 20m kubelet MountVolume.MountDevice failed for volume "pvc-5841825d-31fc-49af-b7f6-dfaefadc7daf" : rpc error: code = Internal desc = 'fsck' found errors on device /dev/rbd1 but could not correct them: fsck from util-linux 2.32.1
/dev/rbd1: Superblock needs_recovery flag is clear, but journal has data.
/dev/rbd1: Run journal anyway

/dev/rbd1: UNEXPECTED INCONSISTENCY; RUN fsck MANUALLY.

Related issues

Future concerns

May need further testing in prd environments


@EnvyusKennys
Copy link
Author

@houz42

internal/rbd/nodeserver.go Outdated Show resolved Hide resolved
internal/rbd/controllerserver.go Outdated Show resolved Hide resolved
internal/rbd/controllerserver.go Outdated Show resolved Hide resolved
internal/util/readonly.go Show resolved Hide resolved
Copy link
Member

@houz42 houz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

internal/rbd/nodeserver.go Outdated Show resolved Hide resolved
@houz42
Copy link
Member

houz42 commented Dec 14, 2022

可以合并了吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants